Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump gopkg.in/yaml.v2 #248

Merged
merged 3 commits into from
Apr 18, 2023
Merged

bump gopkg.in/yaml.v2 #248

merged 3 commits into from
Apr 18, 2023

Conversation

SalDaniele
Copy link
Contributor

@SalDaniele SalDaniele commented Mar 23, 2023 •
edited
Loading

Upgrade gopkg.in/yaml.v2 prior to v2.2.4. Currently this outdated version is indirectly references as follows:

github.com/stretchr/testify requires gopkg.in/yaml.v2 v2.2.2

github.com/go-task/slim-sprig v0.0.0-20210107165309-348f09dbbbc0 requires gitub.com/stretchr/testify v1.5.1, and is required by a number of packages.

To upgrade from yaml <v2.2.4, ginkgo must be migrated to v2.

Additionally, bump the versions of the following to remove indirect dependencies on outdated version of ginkgo, gomega, and slim-sprig:

github.com/onsi/gomega
github.com/containernetworking/cni
github.com/containernetworking/plugins

@SalDaniele
Copy link
Contributor Author

/cc @vrindle

@SalDaniele
Copy link
Contributor Author

SalDaniele commented Mar 28, 2023 •
edited
Loading

Is it possible to get this reviewed / merged?

@coveralls
Copy link

coveralls commented Mar 28, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4578482332

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 7 (42.86%) changed or added relevant lines in 3 files are covered.
  • 23 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 38.027%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/utils/utils.go 0 1 0.0%
pkg/utils/testing.go 1 4 25.0%
Files with Coverage Reduction New Missed Lines %
pkg/utils/testing.go 5 57.89%
pkg/utils/utils.go 18 38.91%
Totals Coverage Status
Change from base Build 4284585998: 0.0%
Covered Lines: 424
Relevant Lines: 1115
💛 - Coveralls

@SalDaniele SalDaniele changed the title bump gopkg.in/yaml.v2 OCPBUGS-6473: bump gopkg.in/yaml.v2 Mar 30, 2023
@SalDaniele
Copy link
Contributor Author

SalDaniele commented Mar 30, 2023 •
edited
Loading

cc @SchSeba

@SalDaniele
Copy link
Contributor Author

SalDaniele commented Mar 31, 2023 •
edited
Loading

cc @wizhaoredhat

@SalDaniele SalDaniele changed the title OCPBUGS-6473: bump gopkg.in/yaml.v2 bump gopkg.in/yaml.v2 Mar 31, 2023
@SchSeba
Copy link
Collaborator

SchSeba commented Apr 2, 2023

there is an issue with the go-lint but there is no output :(

I will need to try and run it locally with the same version to see if it also failed on my laptop

@SalDaniele
Copy link
Contributor Author

Thanks @SchSeba, please let me know if any additional output is provided.

zeeke
zeeke reviewed Apr 5, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@zeeke
Copy link
Member

zeeke commented Apr 5, 2023

@e0ne, @adrianchiris can we have some clues about Mellanox CI failure?

@SalDaniele
Copy link
Contributor Author

@adrianchiris @e0ne Looks like the Mellanox CI is no longer auto-failing, but it has been stuck on pending for over 24 hours. Any idea as to how we can get this PR merged?

@SalDaniele SalDaniele force-pushed the bump-yaml-v2 branch 2 times, most recently from f8354a2 to a2b1e1e Compare April 14, 2023 13:00
@adrianchiris
Copy link
Contributor

/test-all

adrianchiris
adrianchiris reviewed Apr 16, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@adrianchiris
Copy link
Contributor

/test-all

SalDaniele and others added 3 commits April 17, 2023 08:49
@SalDaniele
bump gopkg.in/yaml.v2
2fdbcb2 
Upgrade gopkg.in/yaml.v2 prior to v2.2.4. Currently this outdated version is indirectly references as follows:

github.com/stretchr/testify requires gopkg.in/yaml.v2 v2.2.2

github.com/go-task/slim-sprig v0.0.0-20210107165309-348f09dbbbc0 requires gitub.com/stretchr/testify v1.5.1, and is required by a number of packages.

To upgrade from yaml <v2.2.4, ginkgo must be migrated to v2.

Additionally, bump the versions of the following to remove indirect dependencies on outdated version of ginkgo, gomega, and slim-sprig:

github.com/onsi/gomega
github.com/containernetworking/cni
github.com/containernetworking/plugins

Signed-off-by: Salvatore Daniele <sdaniele@redhat.com>
@SchSeba @SalDaniele
fix golangci-lint issues
eaa631d 
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
@SchSeba @SalDaniele
bump golangci-lint
cacd058 
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
@SalDaniele
Copy link
Contributor Author

Hi @zeeke is it possible to get this merged? Looks like the Mellanox CI is running / passing

@zeeke
Copy link
Member

zeeke commented Apr 18, 2023

/lgtm

@zeeke zeeke merged commit 36db6d9 into k8snetworkplumbingwg:master Apr 18, 2023
@SalDaniele SalDaniele mentioned this pull request Apr 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeeke zeeke zeeke left review comments

@adrianchiris adrianchiris adrianchiris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SalDaniele @coveralls @SchSeba @zeeke @adrianchiris