bump golang to 1.19 #228
Merged
bump golang to 1.19 #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3210213410Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Eoghan1232
approved these changes
Oct 10, 2022
|
/cc @zeeke Can you take a look? |
|
LGTM @e0ne can you take a look? |
|
Hi @e0ne can you take a look? please |
|
Hi @zeeke it's time to merged this PR to master branch? |
SchSeba
reviewed
Oct 24, 2022
There was a problem hiding this comment.
please update the Ci workflows to be sure we are able to build with go 1.19
https://github.com/k8snetworkplumbingwg/sriov-cni/blob/master/.github/workflows/
cyclinder
force-pushed
the
bump_golang
branch
from
36bc96e to
2a71657
Compare
|
Thanks @SchSeba Please approve this to running workflows, thanks |
adrianchiris
requested changes
Oct 25, 2022
Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
cyclinder
force-pushed
the
bump_golang
branch
from
2a71657 to
db57cba
Compare
adrianchiris
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bump golang to 1.19
Signed-off-by: cyclinder qifeng.guo@daocloud.io