Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix golint issue #223

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Conversation

SchSeba
Copy link
Collaborator

@SchSeba SchSeba commented Sep 1, 2022

Signed-off-by: Sebastian Sch sebassch@gmail.com

@coveralls
Copy link

coveralls commented Sep 1, 2022

Pull Request Test Coverage Report for Build 2970855976

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 6 of 9 (66.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 36.724%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/utils/utils.go 4 7 57.14%
Totals Coverage Status
Change from base Build 2732265896: 0.0%
Covered Lines: 213
Relevant Lines: 580

💛 - Coveralls

@SchSeba SchSeba changed the title DO NOT MERGE: test golint issue Fix golint issue Sep 1, 2022
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
@wizhaoredhat
Copy link
Contributor

/lgtm

@SchSeba
Copy link
Collaborator Author

SchSeba commented Sep 1, 2022

/cc @adrianchiris @Eoghan1232

Copy link
Contributor

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@adrianchiris adrianchiris merged commit 921c28c into k8snetworkplumbingwg:master Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants