Release IPAM resources for exited containers #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SRIOV plugin needs to delegate the DEL action to the IPAM plugin to release IPAM resources even for terminated containers without valid network namespace path. Signed-off-by: Yun Zhou <yunz@nvidia.com>
|
+1 |
zshi-redhat
approved these changes
Jan 8, 2021
|
I am just curious how this change will behave when cmdDel is invoked repeatedly with same IPAM and no network namespace? |
pperiyasamy
reviewed
Jan 8, 2021
| if netConf.IPAM.Type != "" { | ||
| err = ipam.ExecDel(netConf.IPAM.Type, args.StdinData) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| } | ||
|
|
||
| // https://github.com/kubernetes/kubernetes/pull/35240 | ||
| if args.Netns == "" { |
There was a problem hiding this comment.
At this time the interface would just be moved into default net namespace (in case of net device) due to container exit, but we still need to rename the interface back to original name.
There was a problem hiding this comment.
That issue, if exists, is then orthogonal to what this PR is trying to fix, right? If rename of an interface is required, then it should be done in a separate PR.
|
@ahalim-intel I think ipam must be able to handle it, if not, it is a bug need to be fixed. But passing this cmdDel to ipam is necessary to avoid ip leakage. |
martinkennelly
approved these changes
Jan 11, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SRIOV plugin needs to delegate the DEL action to the IPAM plugin to
release IPAM resources even for terminated containers without valid
network namespace path.
Signed-off-by: Yun Zhou yunz@nvidia.com