Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONTRIBUTING doc to the project #150

Merged

Conversation

adrianchiris
Copy link
Contributor

This commit adds a CONTRIBUTING document to
SRIOV CNI, it is similar to what is currenlty
present in SRIOV Network Device Plugin project.

The goal of this document is to provide an introduction
to newcomers on the process of creating issues and pull
requests as well as information on community meetings
where this project is discussed.

Signed-off-by: Adrian Chiris adrianc@nvidia.com

This commit adds a CONTRIBUTING document to
SRIOV CNI, it is similar to what is currenlty
present in SRIOV Network Device Plugin project.

The goal of this document is to provide an introduction
to newcomers on the process of creating issues and pull
requests as well as information on community meetings
where this project is discussed.

Signed-off-by: Adrian Chiris <adrianc@nvidia.com>
Copy link
Member

@martinkennelly martinkennelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrianchiris
Copy link
Contributor Author

This has been out here for a while, already approved by one of the maintainers.

will self approve and merge per k8snpwg guidelines

@adrianchiris adrianchiris merged commit bcc60a3 into k8snetworkplumbingwg:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants