Use Salsa framework during release to increase the supply-chain security #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkremser
requested review from
donovanmuller,
k0da,
kuritka,
somaritane and
ytsarev
as code owners
somaritane
suggested changes
Oct 15, 2022
There was a problem hiding this comment.
@jkremser looks awesome!
I suggest reflecting these changes in the dev documentation, also wrt the case when cosign key pair should be regenerated.
Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
✅ Deploy Preview for k8gb-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
ytsarev
approved these changes
Oct 17, 2022
kuritka
approved these changes
Oct 17, 2022
|
@somaritane I've added the docs, can you "ptal" again? |
somaritane
approved these changes
Oct 17, 2022
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how it looks like on my other repo - https://github.com/jkremser/log2rbac-operator/actions/runs/3234735006#summary-8846153907
it relies on 3 new repo secrets:
COSIGN_PRIVATE_KEY,COSIGN_PUBLIC_KEYandCOSIGN_PASSWORDCOSIGN_PASSWORDis a passphrase for the private key. The private key is used for signing the artifacts (container images, provenance files, sboms, checksums). The public key is also part of the repo and is used for verifying the signatures.During the release we push the signatures of container images into container registries so that one can verify the validity of the image. Also some artifacts are published together with the release, check the Assets section on log2rbac release page.
inspired / kudos to https://github.com/philips-labs/slsa-provenance-action/blob/main/.github/workflows/ci.yaml
Signed-off-by: Jirka Kremser jiri.kremser@gmail.com