Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add .status.hosts for better ux #927

Merged
merged 2 commits into from
Jul 22, 2022
Merged

add .status.hosts for better ux #927

merged 2 commits into from
Jul 22, 2022

Conversation

jkremser
Copy link
Member

@jkremser jkremser commented Jul 22, 2022 •
edited
Loading

Issue: #922

λ k get gslb -A
NAMESPACE   NAME                 STRATEGY     GEOTAG
test-gslb   test-gslb            roundRobin   us
test-gslb   test-gslb-failover   failover     us

λ k get gslb -A -owide
NAMESPACE   NAME                 STRATEGY     GEOTAG   HOSTS
test-gslb   test-gslb            roundRobin   us       notfound.cloud.example.com, unhealthy.cloud.example.com, roundrobin.cloud.example.com
test-gslb   test-gslb-failover   failover     us       failover.cloud.example.com

@jkremser
Add hosts as another printer column for gslb resource
10e584e 
Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
kuritka
kuritka previously approved these changes Jul 22, 2022
View reviewed changes
Copy link
Collaborator

@kuritka kuritka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

k0da
k0da previously approved these changes Jul 22, 2022
View reviewed changes
Copy link
Collaborator

@k0da k0da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

somaritane
somaritane previously approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@somaritane somaritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What an eye 🍬 @jkremser ! LGTM 👍

@jkremser
Fix k8gb-io#922: Add handling logic for .status.hosts + tests
f6a3f0a 
The printer column has priority set to non-zero value, so that it's not printed by default.
When using k get gslb -owide, it will be there.

Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
@jkremser jkremser dismissed stale reviews from somaritane, k0da, and kuritka via f6a3f0a July 22, 2022 11:00
@jkremser
Copy link
Member Author

jkremser commented Jul 22, 2022 •
edited
Loading

@somaritane ❓ "N" 👁️ 🍬 :)

Folks, could you "ptal" once again, I had some issue in test (impl was fine and is still the same)

@jkremser jkremser requested review from kuritka and somaritane July 22, 2022 11:08
@jkremser jkremser merged commit 7c61add into k8gb-io:master Jul 22, 2022
@jkremser jkremser deleted the hosts-status branch July 22, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k0da k0da k0da approved these changes

@donovanmuller donovanmuller Awaiting requested review from donovanmuller donovanmuller is a code owner

@ytsarev ytsarev Awaiting requested review from ytsarev ytsarev is a code owner

@kuritka kuritka Awaiting requested review from kuritka kuritka is a code owner

@somaritane somaritane Awaiting requested review from somaritane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkremser @somaritane @k0da @kuritka