Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop irrelevant comment in newly added test #913

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Drop irrelevant comment in newly added test #913

merged 1 commit into from
Jun 22, 2022

Conversation

k0da
Copy link
Collaborator

@k0da k0da commented Jun 22, 2022

Signed-off-by: Dinar Valeev dinar.valeev@absa.africa

@k0da
Drop irrelevant comment in newly added test
07c72f2 
Signed-off-by: Dinar Valeev <dinar.valeev@absa.africa>
jkremser
jkremser approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@jkremser jkremser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could have been some artificial ip like 10.42.42.42 because it's not being used, but lgtm
edit: ti's probably being compared to defaultEdgeDNS1 (1.1.1.1)

@k0da
Copy link
Collaborator Author

k0da commented Jun 22, 2022

It is

@k0da k0da merged commit 8bcb29d into master Jun 22, 2022
@k0da k0da deleted the coredns_LB_ip branch June 22, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkremser jkremser jkremser approved these changes

@kuritka kuritka kuritka approved these changes

@donovanmuller donovanmuller Awaiting requested review from donovanmuller donovanmuller is a code owner

@somaritane somaritane Awaiting requested review from somaritane

@ytsarev ytsarev Awaiting requested review from ytsarev ytsarev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k0da @jkremser @kuritka