Bump the config files for k3d to v1alpha4 format #895
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1alpha3
has been deprecated ink3d@5.3.0
and our build produces the warnings.Unfortunately, there was a breaking change introduced betweenv1alpha3
->v1alpha4
. Their json schema is pretty aggressive and complains about thename
being part of the cluster config. Furthermore, if we remove it from the yaml config and don't specify it during the k3d command, it will be set to some default value (k3d-k3s-cluster or similar) so it needs to be there for the k3d command and needs to be missing in the config files.Also aligning the naming for "edgedns" cluster (edgedns
->edge-dns
), because it wasn't consistent, meaning the file name with the config didn't match the cluster name.UPDATE: The
name
was just moved undermetadata
object.k3d-action should be ok with this change.
Signed-off-by: Jirka Kremser jiri.kremser@gmail.com