Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the config files for k3d to v1alpha4 format #895

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

jkremser
Copy link
Member

@jkremser jkremser commented Jun 2, 2022

v1alpha3 has been deprecated in k3d@5.3.0 and our build produces the warnings.

Unfortunately, there was a breaking change introduced between v1alpha3 -> v1alpha4. Their json schema is pretty aggressive and complains about the name being part of the cluster config. Furthermore, if we remove it from the yaml config and don't specify it during the k3d command, it will be set to some default value (k3d-k3s-cluster or similar) so it needs to be there for the k3d command and needs to be missing in the config files.

Also aligning the naming for "edgedns" cluster (edgedns -> edge-dns), because it wasn't consistent, meaning the file name with the config didn't match the cluster name.

UPDATE: The name was just moved under metadata object.

k3d-action should be ok with this change.

Signed-off-by: Jirka Kremser jiri.kremser@gmail.com

@netlify
Copy link

netlify bot commented Jun 2, 2022

Deploy Preview for k8gb-preview ready!

Name Link
🔨 Latest commit 476c559
🔍 Latest deploy log https://app.netlify.com/sites/k8gb-preview/deploys/62988b331305c40009f541fa
😎 Deploy Preview https://deploy-preview-895--k8gb-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k0da
Copy link
Collaborator

k0da commented Jun 2, 2022

@jkremser I still see a name in v1alpha4:
"metadata": { "type": "object", "properties": { "name": { "description": "Name of the cluster (must be a valid hostname and will be prefixed with 'k3d-'). Example: 'mycluster'.", "type": "string", "format": "hostname"

@k0da
Copy link
Collaborator

k0da commented Jun 2, 2022

It was a point to have name specified in a config but not as argument

@jkremser
Copy link
Member Author

jkremser commented Jun 2, 2022

@jkremser I still see a name in v1alpha4:

hmm, weird

λ k3d version
k3d version v5.4.1
k3s version v1.22.7-k3s1 (default)

λ make deploy-full-local-setup

Creating 2 k8s clusters
/Library/Developer/CommandLineTools/usr/bin/make create-local-cluster CLUSTER_NAME=edge-dns

Create local cluster edge-dns
k3d cluster create edge-dns -c k3d/edge-dns.yaml
FATA[0000] Schema Validation failed for config file k3d/edge-dns.yaml: - (root): Additional property name is not allowed
make[1]: *** [create-local-cluster] Error 1

It was a point to have name specified in a config but not as argument

Could you elaborate more? What was the point? I like the new format better actually.. having the "anonymous" specs (/profile) for the cluster.. well, it still needs to be somewaht personalised because of the nodeport shifts, but this won't affect majority of k3d users.

@jkremser
Copy link
Member Author

jkremser commented Jun 2, 2022

@k0da
Ah found it, it moved under metadata object. Ok I will change this as it was and only change the configs 👍

it looks like they are trying to make it look like a k8s manifest.. I assume that in the next iteration everything will be moved under spec object. Then some crossplane integration or some other thing that will run the control cluster for it ;)

Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
@jkremser jkremser force-pushed the k3d-config-v1alpha4 branch from 476c559 to 6ee17dd Compare June 2, 2022 10:44
@jkremser jkremser merged commit 0c7da00 into k8gb-io:master Jun 3, 2022
@jkremser jkremser deleted the k3d-config-v1alpha4 branch June 3, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants