-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kuar web app as another demo application #894
Conversation
Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
looks good, shouldn't it have some reference to Makefile (deploy.sh execution), or installation directly from Makefile ? |
That's what I wanted to avoid. I think it's pretty complicated as it is. Maybe after the refactoring. |
@jkremser, looks good. |
Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
✅ Deploy Preview for k8gb-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for k8gb-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkremser, looks awesome, just a few things to make Grammarly happy :)
Co-authored-by: Timofey Ilinykh <ilinytim@gmail.com> Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
Thanks @somaritane for your 👀! All your fixes/suggestions should be there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkremser thanks a lot, lgtm
Related issue: #892
I didn't want to make our makefile even more confusing so it's in a standalone script.
some screens:
Nice feature of the app is that it can simulate a failure from the web ui. So one can set the artificial failure for next 10 readiness probes in the web ui. So that the failover should be done and then switch back. It also has web based "dig" (hence adding the coredns servers to
/etc/resolv.conf
) + file browser where one can see the content of/etc/resolv.conf
. So it's "clicky clicky", but might be handy for demos.Signed-off-by: Jirka Kremser jiri.kremser@gmail.com