Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kuar web app as another demo application #894

Merged
merged 3 commits into from
Jun 9, 2022

Conversation

jkremser
Copy link
Member

@jkremser jkremser commented Jun 1, 2022

Related issue: #892

I didn't want to make our makefile even more confusing so it's in a standalone script.

some screens:
Screenshot 2022-06-01 at 18 04 29
Screenshot 2022-06-01 at 18 04 16

Nice feature of the app is that it can simulate a failure from the web ui. So one can set the artificial failure for next 10 readiness probes in the web ui. So that the failover should be done and then switch back. It also has web based "dig" (hence adding the coredns servers to /etc/resolv.conf) + file browser where one can see the content of /etc/resolv.conf. So it's "clicky clicky", but might be handy for demos.

Signed-off-by: Jirka Kremser jiri.kremser@gmail.com

Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
@kuritka
Copy link
Collaborator

kuritka commented Jun 2, 2022

looks good, shouldn't it have some reference to Makefile (deploy.sh execution), or installation directly from Makefile ?

@jkremser
Copy link
Member Author

jkremser commented Jun 2, 2022

looks good, shouldn't it have some reference to Makefile (deploy.sh execution), or installation directly from Makefile ?

That's what I wanted to avoid. I think it's pretty complicated as it is. Maybe after the refactoring.

kuritka
kuritka previously approved these changes Jun 2, 2022
@somaritane
Copy link
Contributor

@jkremser, looks good.
The related issue should be #892.
Is the plan to deploy kuard along with other test apps? In that case, deploy-test-apps and clean-test-apps makefile targets should be updated.
If not, then I still believe there should be a target for that, something like deploy-kuard-app or similar.
Would be good to update the contributor docs as well.
Otherwise, there's no info for contributors and users on how to deploy and use the app.

Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
@netlify
Copy link

netlify bot commented Jun 7, 2022

Deploy Preview for k8gb-preview ready!

Name Link
🔨 Latest commit 2b1edd6
🔍 Latest deploy log https://app.netlify.com/sites/k8gb-preview/deploys/629f2d934281910009f05f0c
😎 Deploy Preview https://deploy-preview-894--k8gb-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jkremser jkremser requested a review from kuritka June 7, 2022 10:52
@netlify
Copy link

netlify bot commented Jun 7, 2022

Deploy Preview for k8gb-preview ready!

Name Link
🔨 Latest commit 54f697c
🔍 Latest deploy log https://app.netlify.com/sites/k8gb-preview/deploys/62a058f48c234c000a9af620
😎 Deploy Preview https://deploy-preview-894--k8gb-preview.netlify.app/docs/local-kuar
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

docs/local-kuar.md Outdated Show resolved Hide resolved
docs/local-kuar.md Outdated Show resolved Hide resolved
Copy link
Contributor

@somaritane somaritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkremser, looks awesome, just a few things to make Grammarly happy :)

docs/local-kuar.md Outdated Show resolved Hide resolved
docs/local-kuar.md Outdated Show resolved Hide resolved
docs/local-kuar.md Outdated Show resolved Hide resolved
docs/local-kuar.md Outdated Show resolved Hide resolved
docs/local-kuar.md Outdated Show resolved Hide resolved
docs/local-kuar.md Outdated Show resolved Hide resolved
Co-authored-by: Timofey Ilinykh <ilinytim@gmail.com>
Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
@jkremser
Copy link
Member Author

jkremser commented Jun 8, 2022

Thanks @somaritane for your 👀! All your fixes/suggestions should be there.

Copy link
Contributor

@somaritane somaritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkremser thanks a lot, lgtm

@jkremser jkremser merged commit ff02839 into k8gb-io:master Jun 9, 2022
@jkremser jkremser deleted the add-kuar branch June 9, 2022 07:49
@jkremser jkremser mentioned this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants