Bump k8s.io/* modules #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OperatorSDK 1.16.0 is currently released and does not affect us in any way. The latest Operator SDK will bump - `k8s.io/api` - `k8s.io/apimachinery` - `k8s.io/client-go` - `sigs.k8s.io/controller-runtime`, which fundamentally changes the logger used inside controller-runtime `github.com/go-logr/logr` (changing from `0.4.x` to `v1.2.0` brings logger API changes) . In this task : - I am bumping the OperatorSDK modules - I am changing the logger adapter because logr API has changed - The change will be 100% required in the latest operator SDK ([see operator SDK go.mod file](https://github.com/operator-framework/operator-sdk/blob/master/go.mod#L36-L40)) Signed-off-by: kuritka <kuritka@gmail.com>
kuritka
requested review from
donovanmuller,
jkremser,
k0da,
somaritane and
ytsarev
as code owners
ytsarev
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OperatorSDK 1.16.0 is currently released and does not affect us in any way.
The latest Operator SDK will bump
k8s.io/api,k8s.io/apimachinery,k8s.io/client-gosigs.k8s.io/controller-runtime, which fundamentally changes the logger used inside controller-runtimegithub.com/go-logr/logr(changing from0.4.0tov1.2.0changes the logger API) .In this task:
(see operator SDK go.mod file)
Signed-off-by: kuritka kuritka@gmail.com