helm: finer control over what is going to be deployed #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkremser
requested review from
donovanmuller,
k0da,
kuritka,
somaritane and
ytsarev
as code owners
ytsarev
reviewed
Jan 1, 2022
chart/k8gb/templates/coredns-cm.yaml
Outdated
| @@ -1,3 +1,4 @@ | |||
| {{- if and .Values.coredns.deployment.enabled }} | |||
There was a problem hiding this comment.
it worked, but it's a mistake, amended
…or k8gb should be deployed Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
jkremser
force-pushed
the
helm-finer-deployment-control
branch
from
2427b23 to
3ab855a
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coredns.deployment.enabled&coredns.rbac.create)k8gb.deployCrds) and/or rbac (k8gb.deployRbac) for k8gb should be deployedMain reason for this change is that I would like to add a terratest for a new feature I am working on (optimisation 2 described in #720) and currently it is not possible to deploy the k8gb AGAIN in the same cluster to a different namespace. I know that the behavior might be undef, because two controllers will be fighting against each other for the C
RUD events. But I want to test only the startup of the operator and if it's able to recognize the labels on node and set the geo tag appropriately. Unfortunatelly, I can't do that w/ current helm chart, because some resources are created globaly in the default namespace (crd, cluster role and cluster role binding). This PR aims to make the deployment of these "global" resources optional. We choose not to be opinionated about the deployment mechanisms people can have so making it more configurable can't hurt.Signed-off-by: Jirka Kremser jiri.kremser@gmail.com