OpenShift support: add permission on ingress finalizer in k8gb rbac #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using ingress resources instead of routes in OpenShift, the update permission is needed on ingresses/finalizers Signed-off-by: Nicolas Smith <nicolasasmith@gmail.com>
nicsmith
requested review from
donovanmuller,
jkremser,
k0da,
kuritka,
somaritane and
ytsarev
as code owners
ytsarev
approved these changes
Dec 23, 2021
kuritka
approved these changes
Dec 23, 2021
jkremser
approved these changes
Dec 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating an ingress resource (networking.k8s.io/v1) with annotations in OpenShift, k8gb does not create the corresponding gslb and logs the following error message:
ERR github.com/AbsaOSS/k8gb/controllers/gslb_controller.go:311 > Glsb creation failed error="gslbs.k8gb.absa.oss \"frontend-podinfo\" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on: , <nil>"This fix grants the update permission on ingresses/finalizers in the k8gb ClusterRole so that Ingress resources can be used in OpenShift.
Tested on: OpenShift 4.8.25
Signed-off-by: Nicolas Smith nicolasasmith@gmail.com