Gracefully finishing deferred calls #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently solved how to exit k8gb and make sure all deferred calls are done. The solution was to run a defer at the very end of the program, which decided whether to run os.Exit(0) or os.Exit(1).
Although this solution works, it is still somewhat difficult to understand and quite error prone from the point of view that from the very start of the program, we have to maintain the state of how the program exits.
The following refactoring uses a different pattern - which is stateless and will be accepted by the kubebuilder when the PR is created.
```go
package main
func main() {
if err := run(); err != nil {
os.Exit(1)
}
}
func run() error {
// Current main() code with logs <-- logging, initializing etc.. is here
return nil
}
```
Signed-off-by: kuritka <kuritka@gmail.com>
kuritka
requested review from
donovanmuller,
jkremser,
k0da,
somaritane and
ytsarev
as code owners
k0da
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently solved how to exit k8gb and make sure all deferred calls are done. The solution was to run a defer at the very end of the program, which decided whether to run os.Exit(0) or os.Exit(1).
Although this solution works, it is still somewhat difficult to understand and quite error prone from the point of view that from the very start of the program, we have to maintain the state of how the program exits.
The following refactoring uses a different pattern - which is stateless and maight be potentionally accepted by the kubebuilder when the PR is created.
Signed-off-by: kuritka kuritka@gmail.com