Use font awesome anchor #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkremser
force-pushed
the
gh-pages-anchor
branch
from
e924785 to
e3e048d
Compare
|
✔️ Deploy Preview for k8gb-preview ready! 🔨 Explore the source changes: 3993475 🔍 Inspect the deploy log: https://app.netlify.com/sites/k8gb-preview/deploys/61ae2b2e395b7e00088b791a 😎 Browse the preview: https://deploy-preview-789--k8gb-preview.netlify.app |
somaritane
reviewed
Dec 6, 2021
_layouts/default.html
Outdated
| @@ -45,7 +46,7 @@ <h2 class="project-tagline">{{ page.description | default: site.description | de | |||
| </header> | |||
|
|
|||
| <main id="content" class="main-content" role="main"> | |||
| {% include anchor_headings.html html=content anchorBody="§" anchorClass="heading-anchor" anchorAttrs="aria-labelledby=\"%html_id%\"" headerAttrs="class=heading" %} | |||
| {% include anchor_headings.html html=content anchorClass="heading-anchor fa fa-anchor" anchorAttrs="aria-labelledby=\"%html_id%\"" headerAttrs="class=heading" %} | |||
There was a problem hiding this comment.
I suggest to use fa-link symbol
instead of fa-anchor
Most documentation-centric themes and CMS are using "link" symbol for header anchors and it became a de-facto standard recognizable by users.
There was a problem hiding this comment.
well, both are better than §. I like the "anchor" anchor better b/c it's aligned w/ the k8s nomenclature but I guess we can be boring predictable in our docs ;) so changing..
somaritane
suggested changes
Dec 6, 2021
Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
jkremser
force-pushed
the
gh-pages-anchor
branch
from
e3e048d to
3993475
Compare
somaritane
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up of #692 (comment)
looks like this:
Signed-off-by: Jirka Kremser jiri.kremser@gmail.com