Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Makefile target for building the website for netlify pr preview #788

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

jkremser
Copy link
Member

@jkremser jkremser commented Dec 6, 2021

Deploy the previews of our website also for pull-requests opened against the gh-pages branch. These can contain changes to CSS, layout, etc. and it would be nice to have a way to check them too before merging (w/o the need to deploy the stuff locally for reviewer).

If/once this get merged I will open a follow-up PR that removes the redundant code from here and call this target instead.

Signed-off-by: Jirka Kremser jiri.kremser@gmail.com

Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
Copy link
Contributor

@somaritane somaritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkremser LGTM 👍

@jkremser jkremser merged commit 5446864 into k8gb-io:gh-pages Dec 6, 2021
@jkremser jkremser deleted the gh-pages-pr-preview branch December 6, 2021 14:47
@jkremser jkremser restored the gh-pages-pr-preview branch May 6, 2022 12:12
@jkremser jkremser deleted the gh-pages-pr-preview branch May 6, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants