Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs about automatic tag during release process + different token #732

Merged
merged 2 commits into from
Nov 15, 2021

Conversation

jkremser
Copy link
Member

@jkremser jkremser commented Nov 15, 2021

Updating docs.

Previously the tag has been pushed, but didn't trigger the release probably because of this. So let's use a different token

edit: added one more thing - contains function was changed to startsWith because when reverting a commit, it takes the original msg and prepends "Revert" which would trigger the event (good catch @ytsarev)

Signed-off-by: Jirka Kremser jiri.kremser@gmail.com

Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
@netlify
Copy link

netlify bot commented Nov 15, 2021

✔️ Deploy Preview for k8gb-preview ready!

🔨 Explore the source changes: 23b0756

🔍 Inspect the deploy log: https://app.netlify.com/sites/k8gb-preview/deploys/61926ea69093cf0007ef04f9

😎 Browse the preview: https://deploy-preview-732--k8gb-preview.netlify.app/contributing

ytsarev
ytsarev previously approved these changes Nov 15, 2021
kuritka
kuritka previously approved these changes Nov 15, 2021
Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
@jkremser jkremser dismissed stale reviews from kuritka and ytsarev via 660cdd5 November 15, 2021 14:42
@jkremser jkremser requested review from kuritka and ytsarev November 15, 2021 14:45
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkremser jkremser merged commit b0729bc into k8gb-io:master Nov 15, 2021
@jkremser jkremser deleted the auto-tag-docs branch November 15, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants