-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RELEASE: v0.8.4 #724
Merged
Merged
RELEASE: v0.8.4 #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytsarev
requested review from
donovanmuller,
jkremser,
k0da,
kuritka and
somaritane
as code owners
November 10, 2021 11:22
ytsarev
force-pushed
the
release-0.8.4
branch
from
November 12, 2021 11:20
93b1507
to
35c2800
Compare
k0da
previously approved these changes
Nov 15, 2021
kuritka
previously approved these changes
Nov 15, 2021
jkremser
requested changes
Nov 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but this should probably wait for #729 so that we can test it
pls change the commit msg to contain RELEASE:
Signed-off-by: Yury Tsarev <yury.tsarev@absa.africa>
ytsarev
force-pushed
the
release-0.8.4
branch
from
November 15, 2021 13:35
35c2800
to
dcfc163
Compare
jkremser
approved these changes
Nov 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
somaritane
approved these changes
Nov 15, 2021
ytsarev
added a commit
that referenced
this pull request
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yury Tsarev yury.tsarev@absa.africa