Push image to docker hub #651 #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AugustasV
requested review from
donovanmuller,
jkremser,
k0da,
kuritka,
somaritane and
ytsarev
as code owners
ytsarev
requested changes
Oct 31, 2021
ytsarev
requested changes
Oct 31, 2021
ytsarev
requested changes
Nov 1, 2021
There was a problem hiding this comment.
Please address suggested changes.
Please also use --signoff to satisfy DCO https://github.com/k8gb-io/k8gb/pull/709/checks?check_run_id=4060681862 .
We are CNCF project and it is a strong requirement.
jkremser
requested changes
Nov 1, 2021
Signed-off-by: AugustasV <reg1nt1z@gmail.com>
Signed-off-by: AugustasV <reg1nt1z@gmail.com>
Signed-off-by: AugustasV <reg1nt1z@gmail.com>
AugustasV
force-pushed
the
push_image_to_dockerhub
branch
from
388d5a2 to
1eca721
Compare
ytsarev
requested changes
Nov 2, 2021
jkremser
requested changes
Nov 2, 2021
Signed-off-by: AugustasV <reg1nt1z@gmail.com>
AugustasV
force-pushed
the
push_image_to_dockerhub
branch
from
dace4f5 to
6e02ed3
Compare
Signed-off-by: AugustasV <reg1nt1z@gmail.com>
AugustasV
force-pushed
the
push_image_to_dockerhub
branch
from
f47a78f to
4d1b763
Compare
jkremser
approved these changes
Nov 4, 2021
ytsarev
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited github CI yaml file to upload artifact into dockerhub during build stage.
Issue #651