yet another olm CI fixes #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkremser
requested review from
donovanmuller,
k0da,
kuritka,
somaritane and
ytsarev
as code owners
…g for pr body - fix 'replaces' relation to the previously submited olm bundle (which release this release replaces), see https://docs.openshift.com/container-platform/4.2/operators/understanding_olm/olm-understanding-olm.html#olm-upgrades-example-upgrade-path_olm-understanding-olm - add DNSEndpoint as owned crd, movind it under required didn't work - some working for pull-requst description: 1) fix the link to the gh action that produces this pr, 2) add better description for `bundleVersion` (if value is set to master) Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
k0da
approved these changes
Nov 1, 2021
kuritka
approved these changes
Nov 1, 2021
ytsarev
reviewed
Nov 1, 2021
| @@ -69,7 +70,7 @@ jobs: | |||
| push-to-fork: k8gb-io/community-operators | |||
| path: sandbox | |||
| commit-message: OLM bundle for k8gb@${{ steps.get_version.outputs.bundleDir }} | |||
| title: OLM bundle for k8gb@${{ steps.get_version.outputs.bundleDir }} | |||
| title: operators k8gb ({{ steps.get_version.outputs.bundleDir }}) | |||
There was a problem hiding this comment.
it's not necessary, but every time we create this PR with this title, it gets automatically renamed to this form
ytsarev
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of unrelated changes, but didn't want to open 3 very small PRs, because the changes are pretty small. If you want I can split them.
fix 'replaces' relation to the previously submited olm bundle (which release this release replaces), see https://docs.openshift.com/container-platform/4.2/operators/understanding_olm/olm-understanding-olm.html#olm-upgrades-example-upgrade-path_olm-understanding-olm (failed check) This utilises the change to
olm-bundletool.add
DNSEndpointasownedcrd, moving it underrequireddidn't work (failed check)improved wording for pull-requst description:
bundleVersion(if value is set to master)Signed-off-by: Jirka Kremser jiri.kremser@gmail.com