Drop socrecard OLM annotation #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't have scorecard tests. Signed-off-by: Dinar Valeev <dinar.valeev@absa.africa>
k0da
requested review from
donovanmuller,
jkremser,
kuritka,
somaritane and
ytsarev
as code owners
jkremser
approved these changes
Oct 27, 2021
There was a problem hiding this comment.
lgtm, if their checks fail that the annotations are missing, we can do this:
https://github.com/k8s-operatorhub/community-operators/pull/227/files#diff-7144a6967bb64fd4a9794eac5ffac8584f21f5aa4d9fd7ca3ecb398c3e266f5bR1
That's what I did on the PR that was merged. Some operators on that repo have it like this:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have scorecard tests.
Signed-off-by: Dinar Valeev dinar.valeev@absa.africa