olm: Fix paths when using version=master + more descriptive PR body #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkremser
requested review from
donovanmuller,
k0da,
kuritka,
somaritane and
ytsarev
as code owners
k0da
reviewed
Oct 26, 2021
.github/workflows/olm_pr.yaml
Outdated
| run: | | ||
| mkdir -p $GITHUB_WORKSPACE/sandbox/community-operators/operators/k8gb/ | ||
| cp -r $GITHUB_WORKSPACE/bundle $GITHUB_WORKSPACE/sandbox/community-operators/operators/k8gb/${{ github.event.inputs.bundleVersion }} | ||
| if [ "${{ steps.get_version.outputs.version }}" == "master" ]; then |
There was a problem hiding this comment.
Can we make this logic as part of the get_version step?
There was a problem hiding this comment.
amended, btw. I can't reuse the version variable as it is w/o changing the bash script
Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
jkremser
force-pushed
the
olm-bundle-paths
branch
from
9b4ec9f to
0caab53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the GHA opens the PR and the files look ok. The paths are broken in case the
versionwas set tomaster.The bundle metadata should be in
/operators/k8gb/x.y.z/manifests/*not in
/community-operators/operators/k8gb/master/manifests/*Also adding better pr description.
Note the checks on upstream repo are currently failing because they had some internal issues, also other PRs are red because of the same issue.
PS. sorry for the spam, it's hard to develop&debug
Signed-off-by: Jirka Kremser jiri.kremser@gmail.com