k8gb_gslb_reconciliation_loops_total per GSLB #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
requested review from
donovanmuller,
jkremser,
k0da,
somaritane and
ytsarev
as code owners
|
@kuritka Please consider splitting or renaming the PR, as the scope of the changes is wider than what the title describes. |
somaritane
suggested changes
Sep 20, 2021
There was a problem hiding this comment.
@kuritka Please consider splitting or renaming the PR, as the scope of the changes is wider than what the title describes.
kuritka
force-pushed
the
update-metrics.md
branch
from
b5ef592 to
3724bdf
Compare
k0da
previously approved these changes
Sep 20, 2021
related to #587 `k8gb_gslb_reconciliation_loops_total` was called per k8gb controller. I decided to change this and count the number of successful reconciliations per GSLB - k8gb_gslb_reconciliation_loops_total becomes to be CounterVec instead of Counter Signed-off-by: kuritka <kuritka@gmail.com>
kuritka
changed the title
kuritka
force-pushed
the
update-metrics.md
branch
from
3724bdf to
568662e
Compare
|
@somaritane done |
k0da
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #587
k8gb_gslb_reconciliation_loops_totalwas called per k8gb controller. I decided to change this and count the number of successful reconciliations per GSLBSigned-off-by: kuritka kuritka@gmail.com