Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable path filtering for terrascan #618

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Sep 13, 2021

We got the proper initial report, not it's fine
to execute this pipe only on chart modifications

Signed-off-by: Yury Tsarev yury.tsarev@absa.africa

kuritka
kuritka previously approved these changes Sep 13, 2021
@somaritane
Copy link
Contributor

@ytsarev do you know what this error is linked to?

Generating SARIF file
2021-09-13T13:38:39.584Z	error	v3/load-dir.go:106	unable to normalize data{error 26 0  yaml: line 25: mapping values are not allowed in this context} {file 15 0 k8gb/templates/operator.yaml <nil>}

https://github.com/k8gb-io/k8gb/pull/618/checks?check_run_id=3587626058#step:4:150

@ytsarev
Copy link
Member Author

ytsarev commented Sep 13, 2021

@somaritane i've reported it upstream a while ago tenable/terrascan#1006

We got the proper initial report, not it's fine
to execute this pipe only on chart modifications

Signed-off-by: Yury Tsarev <yury.tsarev@absa.africa>
Copy link
Contributor

@somaritane somaritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ytsarev ytsarev merged commit b3a58ae into master Sep 13, 2021
@ytsarev ytsarev deleted the terrascan-path-filter branch September 13, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants