Local GoKart #603
Merged
Local GoKart #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
requested review from
donovanmuller,
jkremser,
k0da,
somaritane and
ytsarev
as code owners
kuritka
force-pushed
the
600-gokart-local
branch
from
abca90b
to
7378b27
Compare
related to #600 I was looking to see if GoKArt is part of golang-ci - not at the moment. I have added a make target gokart. Static analysis came out very well, no code changes needed. GoKart is checking code including imported packages, see output: ```shell Using config found at /Users/ab011th/.gokart/analyzers.yml Revving engines VRMMM VRMMM 3...2...1...Go! Race Complete! Analysis took 1.862020787s and 569 Go files were scanned (including imported packages) GoKart found 0 potentially vulnerable functions ``` Signed-off-by: kuritka <kuritka@gmail.com>
kuritka
force-pushed
the
600-gokart-local
branch
from
7378b27
to
29aac5b
Compare
jkremser
approved these changes
Sep 8, 2021
|
it's unrelated to this change, but when I was trying to do full ...
golangci-lint run
WARN [runner] The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner. Replaced by revive.
controllers/providers/dns/infoblox.go:54:11: appendAssign: append result not assigned to the same slice (gocritic)
final := append(local, remote...)
^
make: *** [lint] Error 1and I am not sure if it's ony a "PEBKAC" or some real issue in the gh ci setup.. do we actually run |
ytsarev
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking to see if GoKArt is part of golang-ci - not at the moment.
I have added a make target gokart. Static analysis came out very well, no code changes needed.
GoKart is checking code including imported packages, see output:
Signed-off-by: kuritka kuritka@gmail.com