Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Scan k8gb image by Artifacthub.io (#519)" #524

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Conversation

k0da
Copy link
Collaborator

@k0da k0da commented Jun 15, 2021

This reverts commit f6766a0.

@ytsarev
Copy link
Member

ytsarev commented Jun 15, 2021

@k0da looks like DCO doesn't like pure git reverts without a Sign-off

This reverts commit f6766a0.

Signed-off-by: Dinar Valeev <dinar.valeev@absa.africa>
@k0da
Copy link
Collaborator Author

k0da commented Jun 15, 2021

fxd

@k0da k0da merged commit c80ed98 into master Jun 15, 2021
@k0da
Copy link
Collaborator Author

k0da commented Jun 16, 2021

@tegioz we've reverted Chart.yaml annotation assuming image detection would work, but now we got spammed with messages like:


* unable to initialize Podman client: no podman socket found: stat podman/podman.sock: no such file or directory

* GET https://index.docker.io/v2/absaoss/k8gb/manifests/latest MANIFEST_UNKNOWN: manifest unknown; map[Tag:latest]

Is there a channel we could follow to track artifacthub issues/announcements?
Thanks,

@tegioz
Copy link

tegioz commented Jun 17, 2021

Hi @k0da

It looks like the images annotation is still there, it's visible in your index.yaml file (https://www.k8gb.io/index.yaml) for version 0.8.1. Maybe the reverted change hasn't been published yet? The image you added to the annotation has been added to your package just fine, you can see it here: https://artifacthub.io/packages/helm/k8gb/k8gb.

Screen Shot 2021-06-17 at 08 13 36

Regarding the errors you're getting, the problem seems to be that the latest tag for that image does not exist in the registry. You could push that tag, but I'd recommend you to provide the tag corresponding to the package version if possible:

In your index.yaml, you have:

artifacthub.io/images: |
  - name: k8gb
    image: absaoss/k8gb

and maybe you could do something like this (if you want to provide them manually):

artifacthub.io/images: |
  - name: k8gb
    image: absaoss/k8gb:v0.8.1

If the version tag is used when rendering the manifests from the Helm chart, the image detection should pick it up and you don't need to worry about handling this manually.

To track Artifact Hub announcements you can:

  • Subscribe to the new release notifications in Artifact Hub itself (bell icon on the top right). This way we'll send you an email with the corresponding portion of the changelog every time a new version is released. This will give you the most details, but only on every new release.
  • Join the #artifact-hub channel in the CNCF Slack.
  • Follow us on twitter (@cncfartifacthub).

Hope this helps 👋

@ytsarev
Copy link
Member

ytsarev commented Jun 17, 2021

@tegioz thanks a lot for the detailed clarification, I really appreciate it

@k0da looks like current index.yaml update is depending on the release process/helm publish pipeline https://github.com/k8gb-io/k8gb/commits/gh-pages/index.yaml

@k0da k0da deleted the annotation branch October 14, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants