refactoring suggestions #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
requested review from
donovanmuller,
k0da,
somaritane and
ytsarev
as code owners
kuritka
force-pushed
the
slack-suggestions
branch
from
e885cf9 to
48a7d75
Compare
|
@kuritka please rebase with the master |
kuritka
force-pushed
the
slack-suggestions
branch
from
48a7d75 to
d331382
Compare
- I renamed confusing GslbLoggerAssistant to Gslb in package assistant - I moved edgeDNSServerPort into GslbAssistant structure, instead of pass it through function arguments Signed-off-by: kuritka <kuritka@gmail.com>
kuritka
force-pushed
the
slack-suggestions
branch
from
d331382 to
f140891
Compare
|
@ytsarev, rebased, please review |
ytsarev
approved these changes
Jun 9, 2021
|
@kuritka cool, I will merge it right away for the planned experimental deployment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GslbLoggerAssistanttoGslbAssistantedgeDNSServerPortintoGslbAssistantstructure, instead of passing it through function argumentsSigned-off-by: kuritka kuritka@gmail.com