Update k8gb curl demo to be usable for real deployments #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytsarev
requested review from
donovanmuller,
k0da,
kuritka and
somaritane
as code owners
* Make demo script https ready with optional verbose mode * Simple docker build targets * Paramterize hosts under test in main Makefile * Simplify demo targets and make them single parametrized `demo` Useful to survive end-to-end presentations when your local dns got slammed just before the demo Signed-off-by: Yury Tsarev <yury.tsarev@absa.africa>
ytsarev
force-pushed
the
demo-bad-dns-survival
branch
from
3be572c
to
cfd2687
Compare
somaritane
reviewed
May 27, 2021
somaritane
reviewed
May 27, 2021
somaritane
reviewed
May 27, 2021
kuritka
reviewed
May 28, 2021
Signed-off-by: Yury Tsarev <yury.tsarev@absa.africa>
|
@somaritane @kuritka thanks a lot for the careful review. All suggestions are implemented, please re-review |
kuritka
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
demoUseful to survive end-to-end presentations when your local dns
got slammed just before the demo
Signed-off-by: Yury Tsarev yury.tsarev@absa.africa