Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing clean-test-apps make target #500

Merged
merged 1 commit into from
May 21, 2021

Conversation

somaritane
Copy link
Contributor

Delete the removal of not used podinfo backend deployment from clean-test-apps:

❯ make clean-test-apps
...
service "unhealthy-app" deleted
deployment.apps "unhealthy-app" deleted
helm -n test-gslb uninstall backend
Error: uninstall: Release not loaded: backend: release: not found
make: *** [clean-test-apps] Error 1

Signed-off-by: Timofey Ilinykh timofey.ilinykh@absa.africa

Clean up the removal of not used podinfo backend deployment

Signed-off-by: Timofey Ilinykh <timofey.ilinykh@absa.africa>
@kuritka
Copy link
Collaborator

kuritka commented May 21, 2021

Do we need this target at all ?

@somaritane
Copy link
Contributor Author

Do we need this target at all ?

@kuritka good question. @ytsarev , @k0da any ideas?

@ytsarev
Copy link
Member

ytsarev commented May 21, 2021

@somaritane it's not included in other target or flows but I would leave it around as a symmetric deletion target to deploy-test-apps

@somaritane somaritane merged commit 50b2e3b into master May 21, 2021
@somaritane somaritane deleted the fix-clean-test-apps-target branch May 21, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants