Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor test target #492

Merged
merged 1 commit into from
May 20, 2021
Merged

Refactor test target #492

merged 1 commit into from
May 20, 2021

Conversation

kuritka
Copy link
Collaborator

@kuritka kuritka commented May 19, 2021

test target runs unit tests only while check target runs golic + lint + test

Signed-off-by: kuritka kuritka@gmail.com

ytsarev
ytsarev reviewed May 19, 2021
View reviewed changes
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which scenarios make check is going to be executed? Doesn't look obvious to me.

@kuritka
Copy link
Collaborator Author

kuritka commented May 19, 2021 •
edited
Loading

In which scenarios make check is going to be executed? Doesn't look obvious to me.

It's implementation of yesterday's discussion with @somaritane, where make test would test only, doing no additional steps, while check is doing necessary checks.

make check is an optional step but would be executed before pushing to GitHub by developer. If make check is not executed and anything wrong, build pipeline will reveal the issue.

somaritane
somaritane previously approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@somaritane somaritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ytsarev
ytsarev requested changes May 19, 2021
View reviewed changes
Copy link
Member

@ytsarev ytsarev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then please make it visible in make help and probably mention it in CONTRIBUTING.md ?

@kuritka
Refactor test target
0d86daf 
test: target runs unit tests only while check: target runs golic + lint + test

Signed-off-by: kuritka <kuritka@gmail.com>
@kuritka kuritka force-pushed the refactor-test-target branch from e55e70c to 0d86daf Compare May 20, 2021 08:30
@kuritka kuritka requested review from ytsarev and somaritane May 20, 2021 08:36
@kuritka
Copy link
Collaborator Author

kuritka commented May 20, 2021

Ok, then please make it visible in make help and probably mention it in CONTRIBUTING.md ?

@ytsarev, thx amended

k0da
k0da approved these changes May 20, 2021
View reviewed changes
Copy link
Collaborator

@k0da k0da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuritka kuritka merged commit ea71723 into master May 20, 2021
@kuritka kuritka deleted the refactor-test-target branch May 20, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k0da k0da k0da approved these changes

@ytsarev ytsarev ytsarev approved these changes

@donovanmuller donovanmuller Awaiting requested review from donovanmuller donovanmuller is a code owner

@somaritane somaritane Awaiting requested review from somaritane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kuritka @somaritane @ytsarev @k0da