Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify external-dns deployment #481

Merged
merged 1 commit into from
May 12, 2021
Merged

Unify external-dns deployment #481

merged 1 commit into from
May 12, 2021

Conversation

k0da
Copy link
Collaborator

@k0da k0da commented May 12, 2021

Use single template for Route53 and NS1 external-dns deployments

Signed-off-by: Dinar Valeev dinar.valeev@absa.africa

Use single template for Route53 and NS1 external-dns deployments

Signed-off-by: Dinar Valeev <dinar.valeev@absa.africa>
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also was e2e tested by @k0da

@k0da k0da merged commit 4dd3986 into master May 12, 2021
@k0da k0da deleted the extdns branch May 12, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants