Prepare for 0.8 release #471
Conversation
k0da
requested review from
donovanmuller,
kuritka,
somaritane and
ytsarev
as code owners
Makefile
Outdated
| $(call deploy-local-cluster,$(CLUSTER_GSLB1),$(CLUSTER_GSLB2),$(VERSION),,'k8gb/k8gb') | ||
| $(call deploy-local-cluster,$(CLUSTER_GSLB2),$(CLUSTER_GSLB1),$(VERSION),$(CLUSTER_GSLB2_HELM_ARGS),'k8gb/k8gb') | ||
| $(call deploy-local-cluster,$(CLUSTER_GSLB1),$(CLUSTER_GSLB2),,,'k8gb/k8gb') | ||
| $(call deploy-local-cluster,$(CLUSTER_GSLB2),$(CLUSTER_GSLB1),,$(CLUSTER_GSLB2_HELM_ARGS),'k8gb/k8gb') |
There was a problem hiding this comment.
https://github.com/AbsaOSS/k8gb/blob/bf5bc287c207326cc70bd9ab164f3ed34176f8c8/Makefile#L353
will be confusingly empty
Consider changing
@echo "\n$(YELLOW)Deploy GSLB operator from $3 $(NC)"
to
@echo "\n$(YELLOW)Deploy GSLB operator from ${3:-stable chart} $(NC)"
There was a problem hiding this comment.
@ytsarev thanks for suggestion, amended
There was a problem hiding this comment.
https://github.com/AbsaOSS/k8gb/pull/471/checks?check_run_id=2534570627#step:5:17 unfortunately it takes empty string as a value
There was a problem hiding this comment.
@ytsarev which is fine, it takes "released" image then.
There was a problem hiding this comment.
@k0da i'm talking about empty value in the log statement
There was a problem hiding this comment.
@ytsarev is it confusing? I think making it conditional will complicates make file quite a bit. I don't see harm setting a value to be empty.
There was a problem hiding this comment.
@k0da
Yes, Deploy GSLB operator from <nothing> is a confusing incomplete statement.
There was a problem hiding this comment.
@ytsarev , I see now. Let me think I can fix it
There was a problem hiding this comment.
@ytsarev I think I got it. Please check again.
Signed-off-by: Dinar Valeev <dinar.valeev@absa.africa>
k0da
force-pushed
the
release
branch
4 times, most recently
from
5e0e122 to
d790c0d
Compare
Don't pass version into deploy-with-helm so imageTag is set to the version from released chart. Signed-off-by: Dinar Valeev <dinar.valeev@absa.africa>
| @echo "\n$(YELLOW)Deploy GSLB operator from $3 $(NC)" | ||
| $(call deploy-k8gb-with-helm,$1,$2,$3,$4,$5) | ||
| @echo "\n$(YELLOW)Deploy GSLB operator from ${3} $(NC)" | ||
| $(call deploy-k8gb-with-helm,$1,$2,${3:"stable"=""},$4,$5) |
There was a problem hiding this comment.
If we always pass STABLE_VERSION, why do we need "stable"="" ?
There was a problem hiding this comment.
@ytsarev thats string replacement. So helm imageTag will be empty and latest from chart repo will be taken
Signed-off-by: Dinar Valeev dinar.valeev@absa.africa