Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reconcile immediately when creating zone delegation fails #462

Merged
merged 1 commit into from
May 6, 2021

Conversation

kuritka
Copy link
Collaborator

@kuritka kuritka commented May 3, 2021

closes #463

This PR changes the behavior of zone delegation creation check so that when an error happens, the controller is not forced to re-queue reconciliation immediately.

Signed-off-by: kuritka kuritka@gmail.com

@somaritane
Copy link
Contributor

@kuritka I feel like we're trying to solve the situation with a particular provider and local environment limitations in the upstream project. This might potentially impact users in the future. Probably we should make this change in the reconciliation loop optional for that provider, with the respective option flag. WDYT?

@kuritka kuritka force-pushed the finish_reconciliation_on_infoblox_error2 branch from e23e865 to ed2a0fb Compare May 4, 2021 12:06
@kuritka
Copy link
Collaborator Author

kuritka commented May 4, 2021

@somaritane , updated. The change is independent on provider.

Copy link
Contributor

@somaritane somaritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@somaritane , updated. The change is independent on provider.

@kuritka cool, let's amend the commit message and PR to make them consistent with changes.

controllers/gslb_controller.go Outdated Show resolved Hide resolved
controllers/gslb_controller.go Outdated Show resolved Hide resolved
@kuritka kuritka force-pushed the finish_reconciliation_on_infoblox_error2 branch from ed2a0fb to be25dfd Compare May 5, 2021 16:17
@kuritka kuritka requested a review from somaritane May 5, 2021 16:18
@somaritane somaritane changed the title Don't reconcile Infoblox immediately when creating zone delegation fails Don't reconcile immediately when creating zone delegation fails May 5, 2021
@somaritane somaritane added this to the 0.8 milestone May 6, 2021
closes #463

This PR changes the behavior of zone delegation creation check so that when an error happens, the controller is not forced to re-queue reconciliation immediately.

Signed-off-by: kuritka <kuritka@gmail.com>
@kuritka kuritka force-pushed the finish_reconciliation_on_infoblox_error2 branch from be25dfd to 45c7d4b Compare May 6, 2021 07:46
@somaritane
Copy link
Contributor

@kuritka LGTM 👍

@kuritka
Copy link
Collaborator Author

kuritka commented May 6, 2021

@ytsarev, does this go to v0.8.0 ?

@ytsarev
Copy link
Member

ytsarev commented May 6, 2021

@kuritka sure :)

@kuritka kuritka merged commit 7f7c318 into master May 6, 2021
@kuritka kuritka deleted the finish_reconciliation_on_infoblox_error2 branch May 6, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thin down available Infoblox connections
3 participants