-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't reconcile immediately when creating zone delegation fails #462
Conversation
@kuritka I feel like we're trying to solve the situation with a particular provider and local environment limitations in the upstream project. This might potentially impact users in the future. Probably we should make this change in the reconciliation loop optional for that provider, with the respective option flag. WDYT? |
e23e865
to
ed2a0fb
Compare
@somaritane , updated. The change is independent on provider. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@somaritane , updated. The change is independent on provider.
@kuritka cool, let's amend the commit message and PR to make them consistent with changes.
ed2a0fb
to
be25dfd
Compare
closes #463 This PR changes the behavior of zone delegation creation check so that when an error happens, the controller is not forced to re-queue reconciliation immediately. Signed-off-by: kuritka <kuritka@gmail.com>
be25dfd
to
45c7d4b
Compare
@kuritka LGTM 👍 |
@ytsarev, does this go to v0.8.0 ? |
@kuritka sure :) |
closes #463
This PR changes the behavior of zone delegation creation check so that when an error happens, the controller is not forced to re-queue reconciliation immediately.
Signed-off-by: kuritka kuritka@gmail.com