[Fix] Validate when multiple providers are defined #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
requested review from
donovanmuller,
k0da,
somaritane and
ytsarev
as code owners
|
@kuritka k8gb can operate without edgeDNS provider, e.g. in local scenario or in some edge case environments where zone delegation is configured outside of k8gb. So that's expected. |
somaritane
suggested changes
Apr 16, 2021
ytsarev
requested changes
Apr 16, 2021
kuritka
force-pushed
the
448-fix-fail-on-multiple-providers
branch
2 times, most recently
from
beee1de to
3586b31
Compare
somaritane
reviewed
Apr 19, 2021
somaritane
reviewed
Apr 19, 2021
somaritane
reviewed
Apr 19, 2021
kuritka
force-pushed
the
448-fix-fail-on-multiple-providers
branch
from
3586b31 to
3d517e6
Compare
|
@somaritane, resolved, thanks |
resolves #448 - `controller_test.go` was missing NS1EnabledKey in the cleanup() and configureEnvVar() - rewrite depresolver.getEdgeDNSType(), the function now return one more DNSType: `DNSTypeError` indicating, more than one providers were resolved. Depresolver generates error if finds that state. `DNSTypeNoEdgeDNS` is returned when no provider is recognised and is valid state. - cover functionality by depresolver tests. Signed-off-by: kuritka <kuritka@gmail.com>
kuritka
force-pushed
the
448-fix-fail-on-multiple-providers
branch
from
3d517e6 to
c3c879f
Compare
somaritane
suggested changes
Apr 19, 2021
k0da
approved these changes
Apr 19, 2021
ytsarev
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #448
controller_test.gowas missing NS1EnabledKey in the cleanup() and configureEnvVar(), addedrewrite
depresolver.getEdgeDNSType(), the function now coud return one more DNSType:DNSTypeError.DNSTypeErrorindicates depresolver found more than one provider.DNSTypeErrorgenerates validation error on k8gb startup.DNSTypeNoEdgeDNSis returned when no provider is not recognised. This state passes validation; @ytsarev, is that expected behavior ?functionality covered by depresolver tests.
Signed-off-by: kuritka kuritka@gmail.com