Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: race condition detected #432

Merged
merged 1 commit into from
Apr 8, 2021
Merged

FIX: race condition detected #432

merged 1 commit into from
Apr 8, 2021

Conversation

kuritka
Copy link
Collaborator

@kuritka kuritka commented Apr 8, 2021

terratests failed sometimes

The reason was that GSLB was deleted, although it was already removed by removing ingress. Depending on system performance, sometimes it passed, sometimes not.

k0da
k0da approved these changes Apr 8, 2021
View reviewed changes
Copy link
Collaborator

@k0da k0da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kuritka kuritka merged commit 624934a into master Apr 8, 2021
@kuritka kuritka deleted the terratest-race-condition branch April 8, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k0da k0da k0da approved these changes

@ytsarev ytsarev ytsarev approved these changes

@donovanmuller donovanmuller Awaiting requested review from donovanmuller donovanmuller is a code owner

@somaritane somaritane Awaiting requested review from somaritane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kuritka @ytsarev @k0da