log debug, optimization #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
requested review from
donovanmuller,
k0da,
somaritane and
ytsarev
as code owners
somaritane
reviewed
Mar 23, 2021
somaritane
reviewed
Mar 24, 2021
somaritane
suggested changes
Mar 24, 2021
There was a problem hiding this comment.
@kuritka, looks good, just few suggestions and general questions about log improvements.
kuritka
force-pushed
the
logger-DBG
branch
4 times, most recently
from
7a7a30a
to
930a93a
Compare
|
Amended. I also added to factory logger.Debug().
Str("Format", l.log.Format.String()).
Str("Level", l.log.Level.String()).
Msg("Logger settings")The reason I use |
Closed
somaritane
suggested changes
Mar 24, 2021
There was a problem hiding this comment.
@kuritka , left some extra comments for affected log commands
related to #331 - resolved config and satrtegy is logged by DEBUG - merge Split brain TXT time stamp into one log.Info() message, refactor code ... feel free to come with places where log.Debug() is desirable Co-authored-by: Timofey Ilinykh <timofey.ilinykh@absa.africa>
|
@somaritane, thx for suggestions, amended |
somaritane
reviewed
Mar 25, 2021
somaritane
approved these changes
Mar 25, 2021
There was a problem hiding this comment.
@kuritka, thanks for updates, lgtm!
P.S. There's one comment I left about gopkg ToString() JSON formatting, but I don't think it's in the scope of this PR.
ytsarev
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linked to #331
... feel free to come with places where log.Debug() is desirable