Improve initial logging experience #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somaritane
requested review from
donovanmuller,
k0da,
kuritka and
ytsarev
as code owners
- Wire logging settings via helm chart values - Set `simple` log format as default preference - Use `NO_COLOR` env variable for color settings as per https://no-color.org/ - Disable `NO_COLOR` by default, but enforce for helm deployments - Use `RFC3339` as datetime format for all loggers
somaritane
force-pushed
the
log-defaults-improvements
branch
from
be5d0af to
1fe3678
Compare
somaritane
changed the title
kuritka
requested changes
Mar 23, 2021
Closed
kuritka
approved these changes
Mar 23, 2021
ytsarev
reviewed
Mar 23, 2021
ytsarev
reviewed
Mar 23, 2021
There was a problem hiding this comment.
Looks great, just would be great to get some clarification on test sematics.
We need to be listed on https://no-color.org/ after the merge! :)
ytsarev
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplelog format as default preferenceNO_COLORenv variable for color settings as per https://no-color.org/NO_COLORby default, but enforce for helm deploymentsRFC3339as datetime format for all loggersThis PR contributes to work made in the scope of #331