use gopkg.strings.Format() instead of local utils.ToString() #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
requested review from
donovanmuller,
k0da,
somaritane and
ytsarev
as code owners
kuritka
force-pushed
the
gopkg-string
branch
2 times, most recently
from
fc9c21d
to
dd5441c
Compare
k0da
previously approved these changes
Mar 20, 2021
somaritane
suggested changes
Mar 21, 2021
This was referenced Mar 22, 2021
|
@somaritane amended |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two goals for upgrade
However utils lives in
internalwhich is not enough today(all exists in gopkg now, we can slowly get rid of it).