Change context initialisation, fix helm upgrade #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
requested review from
donovanmuller,
k0da,
somaritane and
ytsarev
as code owners
kuritka
force-pushed
the
168-depresolver-init
branch
2 times, most recently
from
b303649
to
cc3b287
Compare
kuritka
changed the title
ytsarev
previously approved these changes
Nov 16, 2020
kuritka
force-pushed
the
168-depresolver-init
branch
from
cc3b287
to
7d226bc
Compare
somaritane
approved these changes
Nov 18, 2020
kuritka
added a commit
that referenced
this pull request
Nov 18, 2020
Change context initialisation, fix helm upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #168
I tested location for initiating depresolver against blank kubebuilder project. No changes needed in depresolver init location.
I changed context initialisation to Background which is typically used by the main function, initialization, and tests, and as the top-level Context for incoming requests.
I also switched to stable helm repo to pass terratests (already implemented in #201 ).