Extending DepResolver #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somaritane
reviewed
Oct 15, 2020
kuritka
force-pushed
the
170-include-envvars-into-depresolver
branch
3 times, most recently
from
e445f99
to
cd15b29
Compare
somaritane
suggested changes
Oct 16, 2020
ytsarev
requested changes
Oct 16, 2020
kuritka
force-pushed
the
170-include-envvars-into-depresolver
branch
3 times, most recently
from
febb650
to
4ea7841
Compare
related to (#170) extensions validations tests EdgeDNSType move environment variables keys into one place - depresolver TODO:
kuritka
force-pushed
the
170-include-envvars-into-depresolver
branch
from
4ea7841
to
407140b
Compare
somaritane
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to (#170)
The primary purpose of this improvement is to read all k8gb input at one place, validate it and provide to GSLB in typed, well-formatted way. Depresolver is a single point of k8gb inputs now and fail-fast with proper error message if inputs are incorrect.
Inputs:
spec
config
Validations
We implement the new validator, applying various rules to each input.
Tests
75% coverage checking depresolver works as expected. Extensive coverage allow us to make safe refactoring.
Because I introduced new validation rules, I had to update controller_tests.
EdgeDNSType
Providing new computed property EdgeDNSType telling which configuration(s) loaded to depresolver. This allows us to write conditions like
which overall simplify logic and helps in case we provide EdgeDNS implementations by Factory
depresolver as single point of environment variables names
So we are not using names like "DNS_ZONE" directly. Instead, we use depresolver.DnsZone constant. I replaced variables in controller_tests while the DNS code will not access inputs directly. Will be part of following PR.
TODO:
Will follow in next PR (s). Thanks to validator, we can remove validations from GSLB logic and simplify code. Also, accessing depresolver instead of direct access environment variables will enhance code readability. We can more concentrate on DNS logic rather than checking inputs. It will require changes in the code that I postpone to the next PR, because this PR is too large.