Allow adding custom annotations and labels to the k8gb controller #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abaguas
requested review from
donovanmuller,
k0da,
kuritka,
ytsarev and
jkremser
as code owners
I just faced a usecase where I needed to add an istio expection on the k8gb controller via an annotation. However, the chart did not allow it. This PR also allows adding custom labels since this feature may be desired for other usecases. Signed-off-by: Andre Baptista Aguas <andre.aguas@protonmail.com>
abaguas
force-pushed
the
helm/annotations
branch
from
50931a8
to
39605eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced a usecase where I needed to add an istio exception to the k8gb controller via an annotation. However, the chart did not allow it.
This PR also allows adding custom labels since this feature may be desired for other usecases.
Testing
Modify values.yaml by adding/removing labels/annotations and run: