Upgrade to operator-sdk 1.0 #167
Conversation
* Stick to stable podinfo version from dockerhub * Switch to stable column based output of service status as jsonpath output suddenly changed in newer kubectl version
| @@ -650,7 +651,7 @@ func TestGslbController(t *testing.T) { | |||
| t.Fatalf("Can't setup env var: (%v)", err) | |||
| } | |||
| resolver := depresolver.NewDependencyResolver(context.TODO(), cl) | |||
| r.config, err = resolver.ResolveOperatorConfig() | |||
| r.Config, err = resolver.ResolveOperatorConfig() | |||
There was a problem hiding this comment.
I created an additional issue for that
| @@ -3,47 +3,17 @@ module github.com/AbsaOSS/k8gb | |||
| go 1.13 | |||
There was a problem hiding this comment.
Can we try to migrate to go1.15? OR in separate issue ?
There was a problem hiding this comment.
@kuritka I would better not mix it , also go 1.13 spec was created by framework generator so don't really want to override it given complexity of this PR
| ) | ||
|
|
||
| // Pinned to kubernetes-1.16.2 | ||
| replace ( |
There was a problem hiding this comment.
I'm so happy we got rid of that! 🥇
|
|
||
| # editor and IDE paraphernalia | ||
| .idea | ||
| *.swp |
There was a problem hiding this comment.
maybe we can add .vscode as well.
There was a problem hiding this comment.
@kuritka it's actually there https://github.com/AbsaOSS/k8gb/blob/6d05dc68d0c52d70b45e2971e57294b69270bc6f/.gitignore#L100
.gitignore is a bit messy given the merge with upstream, i just sequentially combined them as of now
Upgrade according to https://sdk.operatorframework.io/docs/building-operators/golang/project_migration_guide/
Outstanding issues that were solved
Resolves #166
All tests are passing.