Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Core Dependencies #1627

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Bump Core Dependencies #1627

merged 1 commit into from
Jul 2, 2024

Conversation

kuritka
Copy link
Collaborator

@kuritka kuritka commented Jul 1, 2024 •
edited
Loading

  • Bump Core dependencies
	k8s.io/api v0.30.2
	k8s.io/apimachinery v0.30.2
	k8s.io/client-go v0.30.2
	sigs.k8s.io/controller-runtime v0.18.4
  • Fixing Unit Tests, DeletationTimestamp is immutable can't be changed.
  • minor refactoring to be able to compile
  • Fixing Terratests - strong races. I had to add a waiting loop for localtargets in case of starting and stopping the TestApp.
  • regenerating Mocks
  • Bump controller runtime
  • CRD change when running generate (these are only minor changes to the description)

@kuritka
Bump Core Dependencies
30aebbf 
- Bump Core dependencies
```
	k8s.io/api v0.30.2
	k8s.io/apimachinery v0.30.2
	k8s.io/client-go v0.30.2
	sigs.k8s.io/controller-runtime v0.18.4
```
- Fixing Unit Tests, some things are not supported (e.g.: DeletationTimestamp is immutable can't be changed)
- I'm doing some minor refactoring to make the build thing
- Terratests again strong races. I need to add a wait before k8gb fills localtargets
- regenerating Mocks
- Bump controller runtime
- CRD change when running generate (these are only minor changes to the description)

Signed-off-by: Michal Kuritka <kuritka@gmail.com>
ytsarev
ytsarev approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks a lot for this work 👍

@kuritka kuritka merged commit ad4e798 into master Jul 2, 2024
22 checks passed
@kuritka kuritka deleted the bump-core-deps branch July 2, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytsarev ytsarev ytsarev approved these changes

@donovanmuller donovanmuller Awaiting requested review from donovanmuller donovanmuller is a code owner

@k0da k0da Awaiting requested review from k0da k0da is a code owner

@jkremser jkremser Awaiting requested review from jkremser jkremser is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuritka @ytsarev