Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An attempt to create step-by-step howto #146

Merged
merged 1 commit into from
Jun 26, 2020
Merged

An attempt to create step-by-step howto #146

merged 1 commit into from
Jun 26, 2020

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Jun 24, 2020

No description provided.

kuritka
kuritka previously approved these changes Jun 25, 2020
somaritane
somaritane previously approved these changes Jun 25, 2020
Copy link
Contributor

@donovanmuller donovanmuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor grammar and spelling tweaks.
Also changed all references from k to kubectl to avoid any possible ambiguity as to which command is being executed.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ytsarev ytsarev dismissed stale reviews from somaritane and kuritka via ced5015 June 25, 2020 20:39
Co-authored-by: Donovan Muller <donovan.muller@gmail.com>
@ytsarev
Copy link
Member Author

ytsarev commented Jun 25, 2020

@donovanmuller many thanks for this very thorough review! I've applied all suggestions and squashed the commits

@ytsarev ytsarev merged commit 3001fca into master Jun 26, 2020
@ytsarev ytsarev deleted the howto branch June 26, 2020 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants