-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GO.MOD Dependencies + Upgrade to GO1.19 #1020
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ytsarev , yes, many dependencies throughout the dependency tree are away. With the generics, I guess they also switched to new versions of libraries that don't have so many internal dependencies. It also plays a role that I'm changing both go.sum files, not just one as usually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, thanks for the clarification and the brave PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@somaritane what do you mean by 'many potential changes' ? If terratest is green then we are covered or we do not trust our test suite? |
I'm upgrading the dependency version because of dependabot. Unfortunately the change is huge and all liners started to report different types of errors. That's why I'm upgrading the liners, which in turn requires upgrading the GO version. With all these changes I had to make changes in the code and linters because of deprecated libraries and linters. I also had to make changes to our build pipelines. Signed-off-by: kuritka <kuritka@gmail.com>
9986ba3
to
3775df3
Compare
✅ Deploy Preview for k8gb-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@ytsarev I'm thinking more about potential rebase issues for other open PRs we have, but if @kuritka is OK to manage them, I'm OK too. |
@kuritka we might need to update the docs for 1.19 |
@somaritane , documentation change amended. There is a risk that dependabot will discover some CVE issue, because I radically cut the |
no worries @kuritka , by that time we might be running renovate instead :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
New release of k3d-action solved the problem with importing images [k8gb-io#1020](k3d-io/k3d#1020). We don't need to explicitly specify -mode=tools-node anymore, because this value is now the default. Signed-off-by: kuritka <kuritka@gmail.com>
closes #956
I'm upgrading the dependency version because of dependabot. Unfortunately the change is huge and all linters started to report different types of errors. That's why I'm upgrading the linters, which in turn requires upgrading the GO version. With all these changes I had to make changes in the code and linters because of deprecated libraries and linters. I also had to make changes to our build pipelines.
Signed-off-by: kuritka kuritka@gmail.com