Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated Normalize() call #22

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Conversation

somaritane
Copy link

@somaritane somaritane commented Nov 7, 2021

Replace deprecated plugin.Normalize() call with plugin.OriginsFromArgsOrServerBlock(), following the deprecation warning in the logs:

k8gb-coredns-f658bf78-lcv4d coredns [WARNING] An external plugin (/home/runner/work/coredns-crd-plugin/coredns-crd-plugin/setup.go line 84) is using the deprecated function Normalize. 
This will be removed in a future versions of CoreDNS. 
The plugin should be updated to use OriginsFromArgsOrServerBlock or NormalizeExact instead.

See coredns/coredns#4648 for more information.
Signed-off-by: Timofey Ilinykh timofey.ilinykh@absa.africa

Signed-off-by: Timofey Ilinykh <timofey.ilinykh@absa.africa>
Copy link
Collaborator

@k0da k0da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@somaritane somaritane merged commit 3f946e5 into main Nov 8, 2021
@somaritane somaritane deleted the deprecate-normalize branch November 8, 2021 07:26
somaritane added a commit to k8gb-io/k8gb that referenced this pull request Dec 15, 2021
somaritane pushed a commit to k8gb-io/k8gb that referenced this pull request Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants