Fix make generate to use dapper #4861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <derek.nola@suse.com>
briandowns
approved these changes
Jan 3, 2022
brandond
approved these changes
Jan 3, 2022
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Jan 19, 2022
Signed-off-by: Derek Nola <derek.nola@suse.com>
Merged
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Jan 20, 2022
Signed-off-by: Derek Nola <derek.nola@suse.com>
Merged
dereknola
added a commit
that referenced
this pull request
Jan 20, 2022
* Backport #4861 Signed-off-by: Derek Nola <derek.nola@suse.com> * Update to v1.20.15 Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Jan 20, 2022
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
that referenced
this pull request
Jan 20, 2022
* Backport #4861 Signed-off-by: Derek Nola <derek.nola@suse.com> * Update to v1.22.6 Signed-off-by: Derek Nola <derek.nola@suse.com> * Update tags to k3s-io for v1.22.6 Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Jan 20, 2022
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
that referenced
this pull request
Jan 25, 2022
* Backport #4861 Signed-off-by: Derek Nola <derek.nola@suse.com> * Update tags to k3s-io for v1.21.9 Signed-off-by: Derek Nola <derek.nola@suse.com>
galal-hussein
pushed a commit
to galal-hussein/k3s
that referenced
this pull request
Feb 18, 2022
…ns (k3s-io#4861) Signed-off-by: Derek Nola <derek.nola@suse.com>
galal-hussein
added a commit
that referenced
this pull request
Feb 20, 2022
* Update to v1.21.10 Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> * Upgrade treafik image to 2.6.1 Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> * Upgrade treafik image in image-list Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> * add debug to download script Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> * Enable make generate to use dapper and standardize go and gzip versions (#4861) Signed-off-by: Derek Nola <derek.nola@suse.com> * fix go generate Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> * fix deep copy generated file Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> * Update go.mod Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> Co-authored-by: Derek Nola <derek.nola@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Nola derek.nola@suse.com
Proposed Changes
make generatenow uses dapper to standardize the go and gzip version to be the same run by CI. This solves annoying issues when making chart changes.Updated documentation
Types of Changes
Dev Tool Fix
Verification
make generatenow uses dapperLinked Issues
N/A internal build fix, nothing to QA
User-Facing Change
Further Comments
Was running into issues with how different gzip versions (Ubuntu has 1.10 while apline/CI uses 1.9) would be 1 byte off in compression on #4860