Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[engine-1.21] updating to new signals package in wrangler #4434

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

luthermonson
Copy link
Contributor

Proposed Changes

Updates to using wrangler v0.8.8 which includes fixes to the signal handler to give a exported func to cancel the the context by hand. this is useful in windows services and gives us a way to cancel context to kill all sub-processes and exit gracefully when using windows service manager.

Types of Changes

vendor update, small code change to align k3s to use library slight different and pass in context to containerd

Verification

this will ultimately be used in rke2 windows services, this will be tested by QA when we work on closing the linked issue.

Linked Issues

rancher/rke2#1755

User-Facing Change

none

Further Comments

@luthermonson luthermonson requested a review from a team as a code owner November 9, 2021 04:24
@codecov-commenter
Copy link

Codecov Report

Merging #4434 (0ec5bd5) into engine-1.21 (14cf963) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           engine-1.21    #4434   +/-   ##
============================================
  Coverage        11.54%   11.54%           
============================================
  Files              133      133           
  Lines             8980     8980           
============================================
  Hits              1037     1037           
  Misses            7718     7718           
  Partials           225      225           
Flag Coverage Δ
inttests 0.67% <0.00%> (ø)
unittests 11.20% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/containerd/containerd.go 0.00% <0.00%> (ø)
pkg/cli/agent/agent.go 0.00% <0.00%> (ø)
pkg/cli/etcdsnapshot/etcd_snapshot.go 0.00% <0.00%> (ø)
pkg/cli/server/server.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14cf963...0ec5bd5. Read the comment docs.

@brandond
Copy link
Member

brandond commented Nov 9, 2021

Looks good except for DCO!

Signed-off-by: Luther Monson <luther.monson@gmail.com>
Signed-off-by: Luther Monson <luther.monson@gmail.com>
@dweomer dweomer merged commit 67d079e into k3s-io:engine-1.21 Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants