[release-1.21] Fix log/reap reexec #4376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
briandowns
approved these changes
Nov 1, 2021
galal-hussein
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Ensure that the forked k3s process is started with the correct binary and gets SIGTERM when parent dies.
This restores the behavior previously used by the docker/reexec package.
Types of Changes
bugfix
Verification
Start k3s as systemd unit with
--logargument specified. Restart k3s service; confirm that k3s is stopped and started successfully.Linked Issues
User-Facing Change
Further Comments