Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rancher traefik upgrade suggestion #4324

Merged
merged 2 commits into from
Nov 11, 2021

Conversation

brandond
Copy link
Member

@brandond brandond commented Oct 26, 2021

Proposed Changes

Add dashboard annotation to the Traefik helm chart to prevent Rancher from suggesting upgrades to it.

The 'hidden' annotation only works on charts in the repo, not ones installed to the cluster. This makes it show as 'Managed' in the UI.

Types of Changes

bugfix

Verification

Import K3s cluster into Rancher or install Rancher on K3s. Note that it no longer suggests upgrading the packaged Traefik.

Linked Issues

User-Facing Change

Rancher will no longer suggest upgrading the Traefik chart packaged with K3s.

Further Comments

@brandond brandond requested a review from a team as a code owner October 26, 2021 00:26
@brandond brandond marked this pull request as draft October 26, 2021 02:11
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond force-pushed the fix_rancher_traefik_upgrade branch from 3b20867 to d1d50dd Compare October 27, 2021 04:55
@brandond brandond marked this pull request as ready for review October 27, 2021 05:07
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2021

Codecov Report

Merging #4324 (d1d50dd) into master (ab3d25a) will decrease coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4324      +/-   ##
==========================================
- Coverage   11.52%   11.18%   -0.35%     
==========================================
  Files         135      135              
  Lines        9289     9289              
==========================================
- Hits         1071     1039      -32     
- Misses       7990     8032      +42     
+ Partials      228      218      -10     
Flag Coverage Δ
inttests ?
unittests 11.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/static/zz_generated_bindata.go 0.00% <ø> (ø)
tests/util/cmd.go 0.00% <0.00%> (-42.03%) ⬇️
pkg/flock/flock_unix.go 0.00% <0.00%> (-20.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab3d25a...d1d50dd. Read the comment docs.

Copy link
Member

@dereknola dereknola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The integration test failure is unrelated, feel free to ignore.

@brandond brandond merged commit bc7cdc7 into k3s-io:master Nov 11, 2021
@brandond brandond deleted the fix_rancher_traefik_upgrade branch June 6, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants